Lock Gemfile-shopify to money 0.14.x #353
Conversation
The `Gemfile.shopify` file doesn't specify a version of money to use. I'm not entirely sure _why_ that's the case, but it seems like an unnecessary risk to me that can just lead to headaches. A particular headache I'm currently experiencing (and that's prompting me to lock this) is that Money 0.15 was just released and several tests began to fail because of that. Let's keep the minor version locked for now to prevent breakages introduced by functionality changes.
There was a problem hiding this comment.
We can bump the money gem to 0.15 in a follow up PR
Please do, I have concerns that locking this version without a follow-up fix will cause breakage in applications that use both offsite-payments and money.
On a side note, I wish I had merged #248 😅
Oh don't you worry, only core uses both, no biggie. |
|
@bdewater Do you have someone who can look at this immediately? Without setting the version the CI will continue to fail on master. And I don't have the bandwidth or context for this right now unfortunately. If there are serious concerns and there is someone available shortly to do this I can wait to release for a bit until we can bump to 0.15. Question though, if there were any real problems in core we'd be experiencing them now since this gem (already) doesn't play nice with 0.15, right? |
shopify-shipit-activemerchant
bot
temporarily deployed
to
rubygems
The
Gemfile.shopifyfile doesn't specify a version of money to use. Not having that can lead to issues.A particular problem currently caused by this (and what is prompting me to specify it) is that Money 0.15 was just released which is causing several tests to fail.
Let's keep the minor version locked for now to prevent breakages introduced by functionality changes.
We can bump the money gem to 0.15 in a follow up PR, for now we need to create a release for a fix for Gestpay and get the master CI green.